[klibc] Fwd: Re: Bugfix: offsetof in klibc

[Jon Smirl]

--- Greg KH <greg at kroah.com> wrote:
> From: Greg KH <greg at kroah.com>
> To: Kay Sievers <kay.sievers at vrfy.org>
> CC: Hannes Reinecke <hare at suse.de>, linux-hotplug-devel at lists.sourceforge.net
> Subject: Re: Bugfix: offsetof in klibc
> Date: Thu, 12 Feb 2004 15:52:43 -0800
> 
> On Fri, Feb 13, 2004 at 12:20:55AM +0100, Kay Sievers wrote:
> > On Thu, Feb 12, 2004 at 02:52:07PM -0800, Greg KH wrote:
> > > On Tue, Feb 03, 2004 at 01:12:35PM +0100, Hannes Reinecke wrote:
> > > > Hi all, hpa,
> > > > 
> > > > there is a small typo in stddef.h:offsetof()
> > > > 
> > > > ===== stddef.h 1.1 vs edited =====
> > > > --- 1.1/klibc/klibc/include/stddef.h    Wed Oct 22 19:37:29 2003
> > > > +++ edited/stddef.h     Tue Feb  3 10:16:15 2004
> > > > @@ -19,6 +19,6 @@
> > > >  #endif
> > > > 
> > > >  #undef offsetof
> > > > -#define offsetof(t,m) ((size_t)&((t *)0->m))
> > > > +#define offsetof(t,m) ((size_t)&((t *)0)->m)
> > > > 
> > > >  #endif /* _STDDEF_H */
> > > > 
> > > > otherwise the compiler complains and I suspect it will generated invalid
> 
> > > > code anyway.
> > > 
> > > Don't you mean to send this to the klibc mailing list?
> > 
> > We are using offsetof() now, with the private data db patch :)
> > So we have to fix it too, until klibc is fixed.
> 
> Good point. I fixed our version of it for now.
> 
> thanks,
> 
> greg k-h
> 
> 
> -------------------------------------------------------
> SF.Net is sponsored by: Speed Start Your Linux Apps Now.
> Build and deploy apps & Web services for Linux with
> a free DVD software kit from IBM. Click Now!
> http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
> _______________________________________________
> Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
> Linux-hotplug-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel


=====
Jon Smirl
jonsmirl at yahoo.com

__________________________________
Do you Yahoo!?
Yahoo! Finance: Get your refund fast by filing online.
http://taxes.yahoo.com/filing.html