[klibc] [PATCH] klibc/dash: list side effect explicitly

Sam Ravnborg sam at ravnborg.org
Mon Apr 17 07:01:30 PDT 2006


List side effect in dash Kbuild file explicitly.
Use a simple $(Q): command in both cases.

The better fix would be to teach dash NOT to generate two output files
with one command.

Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
---

diff --git a/usr/dash/Kbuild b/usr/dash/Kbuild
index 0ae06ca..83eb77c 100644
--- a/usr/dash/Kbuild
+++ b/usr/dash/Kbuild
@@ -76,9 +76,13 @@ # Generate builtins{.c + .h}
 quiet_cmd_mkbuiltins = GEN     $@
       cmd_mkbuiltins = mkdir -p $(obj)/bltin && cd $(obj) && \
                        sh $(srctree)/$(src)/mkbuiltins builtins.def
-$(obj)/builtins.h $(obj)/builtins.c: $(src)/mkbuiltins $(obj)/builtins.def
+$(obj)/builtins.c: $(src)/mkbuiltins $(obj)/builtins.def
 	$(call cmd,mkbuiltins)
 
+# side effect..
+$(obj)/builtins.h: $(obj)/builtins.c
+	$(Q):
+
 # Generate init.c
 quiet_cmd_mkinit = GEN     $@
       cmd_mkinit = cd $(obj) && ./mkinit $(addprefix $(srctree)/$(src)/, $(SRCS))
@@ -102,10 +106,9 @@ quiet_cmd_mksyntax = GEN     $@
 $(obj)/syntax.c: $(obj)/mksyntax
 	$(call cmd,mksyntax)
 
-quiet_cmd_mksyntax_h = DUMMY   $@
-      cmd_mksyntax_h = :
+# side effect..
 $(obj)/syntax.h: $(obj)/syntax.c
-	$(call cmd,mksyntax_h)
+	$(Q):
 
 BISON := bison
 



More information about the klibc mailing list