[klibc] [patch] sparc build fix

Fabio Massimo Di Nitto fabbione at ubuntu.com
Tue Apr 18 10:36:44 PDT 2006


Sam Ravnborg wrote:
> On Tue, Apr 18, 2006 at 06:19:47PM +0200, maximilian attems wrote:

>> -arch/$(KLIBCARCH)/sdiv.S: arch/$(KLIBCARCH)/divrem.m4
>> +arch/$(KLIBCARCH)/sdiv.o: arch/$(KLIBCARCH)/sdiv.S
> This is wrong. It will not work in the kernel.
> You have to use:
> $(obj)/$(KLIBCARCH)/file.o: $(obj)/$(KLIBCARCH)/file.S

Ok, i never built klibc in the kernel but only externally.


>> +klibc/arch/$(KLIBCARCH)/sdiv.S: klibc/arch/$(KLIBCARCH)/divrem.m4
>>  	@echo 'building $@ from $^'
>>  	@(echo "define(NAME,\`.div')define(OP,\`div')define(S,\`true')"; \
>>  	 cat $^) | m4 > $@
>>  	@chmod 444 $@
> The chmod seems pointless here. Needed due to some strange umask
> setting?

This isn't coming from my patch..

> 
> And there is room for some consolidation and we also want to rebuild
> if commandline changes.
> Care to test following untested patch (has no sparc toolchain atm)
> 

will do in a few hours. my sparcs are powered down atm.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.



More information about the klibc mailing list