[klibc] [mips] fix path of linker script
sam at ravnborg.org
Sun Jan 8 11:58:07 PST 2006
On Sun, Jan 08, 2006 at 07:50:33PM +0000, Martin Michlmayr wrote:
> * Sam Ravnborg <sam at ravnborg.org> [2006-01-08 20:15]:
> > If you use $(src) the change will work in both trees - like this:
> > > +SHAREDFLAGS = -T $(src)/arch/$(ARCH)/klibc.ld
> > We like klibc to be buildable both as standalone and in the kernel.
> > Untested - so please test before resubmit...
> Tested - works, thanks.
As a nice path submitter you should repeat the changelog entry so it is
trivial for hpa to apply your patch.
With this mail hpa has to go back and pick the old changelog entry in
another mail and manually add it to your mail.
Compare that to a situation where hpa only have to delete say 15 lines of
Not a big deal for a single patch, but with current patch flood for
klibc I bet it matters for hpa.
> diff -urN klibc-1.1.16~/klibc/arch/mips/MCONFIG klibc-1.1.16/klibc/arch/mips/MCONFIG
> --- klibc-1.1.16~/klibc/arch/mips/MCONFIG 2006-01-06 06:11:43.000000000 +0000
> +++ klibc-1.1.16/klibc/arch/mips/MCONFIG 2006-01-08 19:49:57.000000000 +0000
> @@ -12,4 +12,4 @@
> BITSIZE = 32
> # Extra linkflags when building the shared version of the library
> -SHAREDFLAGS = -T arch/$(ARCH)/klibc.ld
> +SHAREDFLAGS = -T $(src)/arch/$(ARCH)/klibc.ld
> Martin Michlmayr
More information about the klibc