[klibc] EXTRA_KLIBCCFLAGS and dash

[Sam Ravnborg]

On Sat, Jul 08, 2006 at 05:19:52PM +0200, Martin Schlemmer wrote:
> Hi,
> 
> Dash currently sets EXTRA_KLIBCCFLAGS, so if you set it to something
> else, it fails to build.  Not sure if the following is correct, but it
> seems to work.
> 
> 
> diff --git a/usr/dash/Kbuild b/usr/dash/Kbuild
> index 8e5184e..6e743f8 100644
> --- a/usr/dash/Kbuild
> +++ b/usr/dash/Kbuild
> @@ -18,7 +18,7 @@ DEFAULT_INCLUDES := \
>         -I$(srctree)/$(src) -I$(objtree)/$(obj) \
>         -include $(srctree)/$(src)/config.h
> 
> -EXTRA_KLIBCCFLAGS := $(DEFS) $(DEFAULT_INCLUDES) $(CPPFLAGS) $(CFLAGS)
> +KLIBCCFLAGS += $(DEFS) $(DEFAULT_INCLUDES) $(CPPFLAGS) $(CFLAGS)
>  HOST_EXTRACFLAGS := $(CPPFLAGS_FOR_BUILD) $(CFLAGS_FOR_BUILD)

This is bogus. KLIBCCFLAGS is a internal thing that users shall not fool
with.
EXTRA_KLIBCCFLAGS is exactly used for this purpose. And if it does not
work then we shall fix kbuild - we shall not circumvent it.

	Sam