[klibc] identify DHCP requests

Geert Stappers stappers at stappers.nl
Sun Jul 23 13:46:26 PDT 2006


This a repost of a Mon, Jul 03, 2006 at 03:43:36PM +0200, Geert Stappers
message, with minor changes. It is for getting feedback
on a proposed patch.

> > This thread started with a posting that is archived
> > at http://www.zytor.com/pipermail/klibc/2006-June/001652.html
> > 
> > On Thu, Jun 22, 2006 at 08:03:18PM -0700, H. Peter Anvin wrote:
> > > maximilian attems wrote:
> > > >
> > > >which more generic string do you propose?
> > > > 
> > > 
> > > What does the in-kernel code do now?  I'm guessing it sends nothing; in 
> > > which case we can make it a command-line option to send anything, but 
> > > shouldn't do it by default.
> > 
> > My proposal/request is to split the patch in two parts;
> > an include filename part and the controversial "Vendor Class" part.
> 
> The controversial patch is 
> 
> - --- ../../../../klibc-1.3.35/usr/kinit/ipconfig/dhcp_proto.c 2006-06-08 17:47:18.000000000 +0200
> +++ dhcp_proto.c        2006-07-03 15:12:53.000000000 +0200
> @@ -46,6 +46,7 @@
>  };
> 
>  static uint8_t dhcp_end[] = {
> +       60,5,'k','l','i','b','c',  /* Vendor Class */
>         255,
>  };
> 
> 
> It sends hardcoded the DHCP Vendor Class.
> It surely does something else then the in-kernel code,
> but that is the whole idea about making DHCP requests identifible.
> 
> Making the Vendor Class string a command line option
> would mean to build the whole DHCP packet in RAM,
> where it now resides in ROM.
> I have not researched/explored what the increase in code
> would be for the command line parsing.
> 
> 
> I would also be happy with:
> 
> 
--- ../../../../klibc-1.3.35/usr/kinit/ipconfig/dhcp_proto.c 2006-06-08 17:47:18.000000000 +0200
+++ dhcp_proto.c        2006-07-03 15:12:53.000000000 +0200
@@ -46,6 +46,7 @@
 };

 static uint8_t dhcp_end[] = {
+       /* 60,5,'k','l','i','b','c',   Vendor Class */
        255,
 };



> It makes live of people who need the identify the DHCP reqeust
> some what easier.

Because the reseach where to add the identifier is allready done.
(and doesn't need to be done again)

Cheers
Geert Stappers
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://www.zytor.com/pipermail/klibc/attachments/20060723/c7d9f7ef/attachment.bin 


More information about the klibc mailing list