[klibc] [patch] bitops.h don't use likely/unlikely outside __KERNEL__

Heiko Carstens heiko.carstens at de.ibm.com
Wed Jun 21 00:47:24 PDT 2006


On Wed, Jun 21, 2006 at 12:51:56AM +0200, Arnd Bergmann wrote:
> On Wednesday 21 June 2006 00:27, H. Peter Anvin wrote:
> > More fundamentally busted seems to be that this function gets included at all from a 
> > userspace build. ?This chain seems to be <sys/types.h> -> <linux/posix_types.h> -> -> 
> > <asm/posix_types.h> -> <asm/bitops.h>.
> > 
> > This appears to come from the definitions of __FD_*() in <asm/posix_types.h>; it would 
> > probably be cleaner to just open-code those, since they don't need stuff like ffs/ffz.
> > 
> That change is already in the queue for 2.6.18, IIRC. Dwmw2 stumbled over it as well
> in the headers_install tree.

Both of these patches will fix this and should be merged for 2.6.18:

http://www.ussg.iu.edu/hypermail/linux/kernel/0606.1/1941.html
http://www.ussg.iu.edu/hypermail/linux/kernel/0606.1/1983.html



More information about the klibc mailing list