[klibc] Patch queue pushed out

maximilian attems max at stro.at
Tue Aug 11 08:55:05 PDT 2009

On Tue, Aug 11, 2009 at 05:49:12PM +0200, Thomas Bächler wrote:
> Let me explain the Arch Linux patches:
> http://repos.archlinux.org/viewvc.cgi/klibc/trunk/klibc-Kbuild.patch?revision=12688&view=markup
> klibc-Kbuild.patch just omits a few executables in the build procedure, 
> and replaces a few static ones with shared ones, nothing fancy.

remember to have asked that for hpa.

could you split that up in two?
so that the shared one could maybe reach upstream if hpa acks?
the other part is arxlinux specific indeed.
> http://repos.archlinux.org/viewvc.cgi/klibc/trunk/klibc-compile-shared-by-default.patch?revision=1&view=markup
> klibc-compile-shared-by-default.patch: I found it stupid to ship all our 
> klibc-applications as static binaries, when we were going to have the 
> klibc.so library in the initramfs anyway. It was just convenient to make 
> it the default.

> http://repos.archlinux.org/viewvc.cgi/klibc/trunk/klibc-fix-2.6.28-includes.patch?revision=22942&view=markup
> klibc-fix-2.6.28-includes.patch: This is an ugly hack to make klibc even 
> build with merged x86_64 and i386, klibc was never adjusted to this 
> unification and thus always failed.

as hpa is x86 maintainer, let him speak a word on this,
looks hackish.
> http://repos.archlinux.org/viewvc.cgi/klibc/trunk/klibc-x86_64-fix-io.h.patch?revision=12688&view=markup
> klibc-x86_64-fix-io.h.patch: This is a trivial fix for three typoes that 
> prevented 915resolution from building with klibc.

> http://repos.archlinux.org/viewvc.cgi/klibc/trunk/kinit-fix-init-cmdline.patch?revision=41787&view=markup
> kinit-fix-cmdline.patch: Ever since we used klibc, "init=/bin/sh" 
> stopped working, as kinit always passed the kitchensink to init 
> (/sbin/init doesn't care, /bin/sh does and thus fails). The way I 
> understood it, everything _before_ the first -- should be passed to 
> init, while the rest is for kinit (combined with what was on the kernel 
> commandline to build some mount options and more). This simple patch 
> implements this behaviour.

we had a similar trouble with initramfs-tools and upstart.
some init implementation do cleanup on ENV they receive other not.
to me it feels right to assume they don't. so ack too.
also as archlinux is the distro actualy using kinit,
guess your point on kinit itself has lots of weight.

could you prepare a git tree somewhere with corresponding acked patches?
hpa likes when the subject of the patch is prepended with [klibc]
and has meaningfull desc (but guess you are fluent with git am or


More information about the klibc mailing list