[klibc] (fwd) dash fix for job control off warning

maximilian attems max at stro.at
Fri Apr 2 07:32:20 PDT 2010

----- Forwarded message from "H. Peter Anvin" <hpa at zytor.com> -----

Date: Mon, 29 Mar 2010 15:07:01 -0700
From: "H. Peter Anvin" <hpa at zytor.com>
To: maximilian attems <max at stro.at>
Cc: Colin Watson <cjwatson at ubuntu.com>, klibc at zytor.com,
	Herbert Xu <herbert at gondor.apana.org.au>,
	Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
Subject: Re: [klibc] [git pull v3] dash, sh4, ipconfig, dprintf, fstype,

On 03/27/2010 05:58 PM, maximilian attems wrote:
> hello hpa!
> added on top of queue ext4 fix, that Ubuntu is carrying from cjwatson.
> Got missed out in previous pull requests. Btrfs recognition in fstype.
> the patch queue contains sync with latest dash, sh4 fix by Debian porters,
> dprintf usage in ipconfig, kinit and nfsmount instead of buggy DEBUG
> macro. ipconfig memcpy usage to avoid strict aliasing warnings.
> Some interesting README's got renamed for easier packaging.
> Bonus is sparc32 socket test.

Pulled this; there seems to be a problem with the new version of dash
with job control off.  I can't tell if it is just a warning or is a
manifest bug.

The solution is simple:

--- a/usr/dash/jobs.h
+++ b/usr/dash/jobs.h
@@ -105,5 +105,5 @@ int waitforjob(struct job *);
 int stoppedjobs(void);

 #if ! JOBS
-#define setjobctl(on)  /* do nothing */
+#define setjobctl(on) ((void)(on))     /* do nothing */

... to keep the code syntactically valid even when setjobctl() is used
as the body of an if statement.


----- End forwarded message -----

More information about the klibc mailing list