[klibc] [patch v2] dash fix for job control off warning

maximilian attems max at stro.at
Tue Apr 6 15:19:25 PDT 2010

fix subject and added warning to patch mail,
thanks for review.

----- Forwarded message from "H. Peter Anvin" <hpa at zytor.com> -----

Date: Mon, 29 Mar 2010 15:07:01 -0700
From: "H. Peter Anvin" <hpa at zytor.com>
To: maximilian attems <max at stro.at>
Cc: Colin Watson <cjwatson at ubuntu.com>, klibc at zytor.com,
	Herbert Xu <herbert at gondor.apana.org.au>,
	Nobuhiro Iwamatsu <iwamatsu at nigauri.org>
Subject: Re: [klibc] dash fix for job control off warning

There seems to be a problem with the new version of dash
with job control off.  I can't tell if it is just a warning or is a
manifest bug.

usr/dash/trap.c: In function `exitshell':
usr/dash/trap.c:376: warning: suggest braces around empty body in an `if' statement

The solution is simple:

--- a/usr/dash/jobs.h
+++ b/usr/dash/jobs.h
@@ -105,5 +105,5 @@ int waitforjob(struct job *);
 int stoppedjobs(void);

 #if ! JOBS
-#define setjobctl(on)  /* do nothing */
+#define setjobctl(on) ((void)(on))     /* do nothing */

... to keep the code syntactically valid even when setjobctl() is used
as the body of an if statement.


----- End forwarded message -----

More information about the klibc mailing list