[klibc] proposed faccessat

[maximilian attems]

On Tue, Apr 20, 2010 at 12:08:02PM +0800, Herbert Xu wrote:
> On Tue, Apr 20, 2010 at 06:04:06AM +0200, maximilian attems wrote:
> > patch is also available in current patch queue:
> > git pull git://git.debian.org/users/maks/klibc.git maks
> > 
> > Run it on latest dash and it could still test readable files as readable.
> > 
> > >From b454cb46858debcd88e27964a94ebd9cbebf35f6 Mon Sep 17 00:00:00 2001
> > From: maximilian attems <max at stro.at>
> > Date: Fri, 16 Apr 2010 05:18:40 +0200
> > Subject: [PATCH] [klibc] add minimal faccessat()
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > 
> > Implement as wrapper around sys_faccessat().
> 
> This isn't quite right. 

why, what do you miss?

> I'd suggest we either tweak dash's build
> to not detect faccessat on klibc, or implement faccessat properly
> in klibc by doing what the glibc version does.

hmm which of those cornercases do you expect in an initramfs?
(I didn't look at glibc faccessat() merely at faccessat(2).)
sorry I may not have fully understood what you expect faccessat()
there to be good.

thanks for review.

-- 
maks