[klibc] ipconfig: DHCP fixes

Louis Rilling Louis.Rilling at kerlabs.com
Tue Mar 16 08:29:09 PDT 2010


On 16/03/10 16:09 +0100, maximilian attems wrote:
> On Tue, Mar 16, 2010 at 03:57:00PM +0100, Louis Rilling wrote:
> > 
> > Really? My patches are based on latest git (as far as I can fetch):
> > 
> >     commit 2faf233ada1aea0f09e5f730205b8d4db363be7f
> >     Author: H. Peter Anvin <hpa at zytor.com>
> >     Date:   Sat Mar 13 23:22:56 2010 +0000
> > 
> >     [klibc] 1.5.16 released, next version is 1.5.17
> 
> okay let me check, one sec, that would suck if they'd not be in.
> so we are speaking here of:
> http://git.debian.org/?p=kernel/klibc.git;a=summary
> branch master I hope

Exactly.

> 
> this one contains:
> cfc8d64
> maximilian attems
> [klibc] ipconfig: set null ciaddr on DHCPREQUEST during SELECTING state

This very commit introduced the bug that my second patch fixes. It's mentioned
in the log.

> 
> 
> b4bad5b
> Aron Griffis
> ipconfig: omit zero-length DHCP vendor_class_identifier

And this very commit introduced the bug that my first patch fixes. Again, it's
mentioned in the log.

Maybe my patches' logs are confusing?

> 
>  
> > I actually used latest debian:
> > 
> >     commit c93c1518a29fadd193ad89d54431a5ce015c8b26
> >     Author: Jan Hauke Rahm <jhr at debian.org>
> >     Date:   Mon Mar 15 23:48:08 2010 +0100
> > 
> >     klibc change packaging
> 
> yep aboves was a birthday present like change, so happy. :)

And now quilt bugs me because I'm not using dpkg-source…

>  
> > which includes all but the version change above.
> 
> again this seems confusing.

Commit c93c1518 (debian master) does not have 2faf233a (klibc master) but only
2faf233a~ as ancestor. You did the merge actually: 1ade1a3f

>  
> > BTW, did you receive the patches? I got none of them through klibc yet???
> 
> yep afais, I all got them through klibc,
> beware that the klibc mailinglist is slow if you are not whitelisted
> or such.

The surprising thing is that I received only the cover letter…

>  
> thanks for your checks.
> 
> sunny greetings

Thanks to you, but I fail to see the sun here :-/

Louis

-- 
Dr Louis Rilling			Kerlabs
Skype: louis.rilling			Batiment Germanium
Phone: (+33|0) 6 80 89 08 23		80 avenue des Buttes de Coesmes
http://www.kerlabs.com/			35700 Rennes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://www.zytor.com/pipermail/klibc/attachments/20100316/08d467a2/attachment.sig>


More information about the klibc mailing list