[klibc] [git pull v3] dash, sh4, ipconfig, dprintf, fstype, README's

H. Peter Anvin hpa at zytor.com
Mon Mar 29 15:07:01 PDT 2010

On 03/27/2010 05:58 PM, maximilian attems wrote:
> hello hpa!
> added on top of queue ext4 fix, that Ubuntu is carrying from cjwatson.
> Got missed out in previous pull requests. Btrfs recognition in fstype.
> the patch queue contains sync with latest dash, sh4 fix by Debian porters,
> dprintf usage in ipconfig, kinit and nfsmount instead of buggy DEBUG
> macro. ipconfig memcpy usage to avoid strict aliasing warnings.
> Some interesting README's got renamed for easier packaging.
> Bonus is sparc32 socket test.

Pulled this; there seems to be a problem with the new version of dash
with job control off.  I can't tell if it is just a warning or is a
manifest bug.

The solution is simple:

--- a/usr/dash/jobs.h
+++ b/usr/dash/jobs.h
@@ -105,5 +105,5 @@ int waitforjob(struct job *);
 int stoppedjobs(void);

 #if ! JOBS
-#define setjobctl(on)  /* do nothing */
+#define setjobctl(on) ((void)(on))     /* do nothing */

... to keep the code syntactically valid even when setjobctl() is used
as the body of an if statement.


More information about the klibc mailing list