[klibc] [PATCH] Avoid infinite loop during build with make 3.82
maximilian attems
max at stro.at
Wed Nov 10 02:59:36 PST 2010
On Wed, Nov 10, 2010 at 11:23:34AM +0100, Erik Johansson wrote:
> Remove FORCE from the list used by if_changed and friends. Otherwise the target
> will always be considered out of date when built with make 3.82.
>
> >From GNU make 3.82 NEWS file:
>
> * WARNING: Backward-incompatibility!
> The '$?' variable now contains all prerequisites that caused the target to
> be considered out of date, even if they do not exist (previously only
> existing targets were provided in $?).
thanks looks good at first sight.
Erik or kelly could you please test the patch on your build?
if positive, happy to release klibc-1.5.21 with it.
> usr/klibc/socketcalls/Kbuild | 3 +++
> usr/klibc/syscalls/Kbuild | 3 +++
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/usr/klibc/socketcalls/Kbuild b/usr/klibc/socketcalls/Kbuild
> index 648c928..d70b15f 100644
> --- a/usr/klibc/socketcalls/Kbuild
> +++ b/usr/klibc/socketcalls/Kbuild
> @@ -48,3 +48,6 @@ $(obj)/socketcalls.mk:
> $(srctree)/$(KLIBCSRC)/socketcalls.pl \
> $(obj)/SOCKETCALLS.i \
> $(src)/socketcommon.h
> $(call cmd,socketcalls)
> +
> +# Used by if_changed and friends
> +PHONY += FORCE
> diff --git a/usr/klibc/syscalls/Kbuild b/usr/klibc/syscalls/Kbuild
> index 4dbbc31..c94f65c 100644
> --- a/usr/klibc/syscalls/Kbuild
> +++ b/usr/klibc/syscalls/Kbuild
> @@ -95,3 +95,6 @@ $(obj)/syscalls.mk:
> $(srctree)/$(KLIBCSRC)/syscalls.pl $(obj)/SYSCALLS.i \
> $(src)/syscommon.h $(obj)/syscalls.nrs \
> $(obj)/typesize.bin FORCE
> $(call if_changed,syscalls)
> +
> +# Used by if_changed and friends
> +PHONY += FORCE
> --
> 1.7.2.3
More information about the klibc
mailing list