[klibc] [PATCH 2/2] utils: cleanup unused includes

maximilian attems max at stro.at
Sat Nov 20 14:16:17 PST 2010


On Sat, Nov 20, 2010 at 10:48:34PM +0100, maximilian attems wrote:
> several errno.h for no good reasons.
> cleanup losesetup which is not using getopt_long,
> thus doesn't need getopt.h nor stdarg.h
> 
> Signed-off-by: maximilian attems <max at stro.at>
> ---
>  usr/utils/dmesg.c   |    1 -
>  usr/utils/losetup.c |    3 ---
>  usr/utils/mkfifo.c  |    1 -
>  usr/utils/nuke.c    |    1 -
>  usr/utils/umount.c  |    1 -
>  5 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/usr/utils/dmesg.c b/usr/utils/dmesg.c
> index 61e047e..1960713 100644
> --- a/usr/utils/dmesg.c
> +++ b/usr/utils/dmesg.c
> @@ -1,5 +1,4 @@
>  #include <unistd.h>
> -#include <errno.h>
>  #include <stdio.h>
>  #include <ctype.h>
>  #include <stdlib.h>
> diff --git a/usr/utils/losetup.c b/usr/utils/losetup.c
> index 1a47fa9..025deb6 100644
> --- a/usr/utils/losetup.c
> +++ b/usr/utils/losetup.c
> @@ -349,9 +349,6 @@ int del_loop (const char *device)
>  }
>  
>  
> -#include <getopt.h>
> -#include <stdarg.h>

this is wrong on recheck, uses va_*() stuff, will move it up.
will repost this one.

> -
>  int verbose = 0;
>  char *progname;
>  
> diff --git a/usr/utils/mkfifo.c b/usr/utils/mkfifo.c
> index f2ac35f..5a758b2 100644
> --- a/usr/utils/mkfifo.c
> +++ b/usr/utils/mkfifo.c
> @@ -1,6 +1,5 @@
>  #include <sys/stat.h>
>  #include <sys/types.h>
> -#include <errno.h>
>  #include <fcntl.h>
>  #include <signal.h>
>  #include <stdio.h>
> diff --git a/usr/utils/nuke.c b/usr/utils/nuke.c
> index 0a282c8..93a04af 100644
> --- a/usr/utils/nuke.c
> +++ b/usr/utils/nuke.c
> @@ -32,7 +32,6 @@
>   * do anything.
>   */
>  
> -#include <alloca.h>
>  #include <assert.h>
>  #include <dirent.h>
>  #include <errno.h>
> diff --git a/usr/utils/umount.c b/usr/utils/umount.c
> index 4469297..41275f7 100644
> --- a/usr/utils/umount.c
> +++ b/usr/utils/umount.c
> @@ -2,7 +2,6 @@
>   * by rmk
>   */
>  #include <sys/mount.h>
> -#include <errno.h>
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
> -- 
> 1.7.2.3
> 



More information about the klibc mailing list