[klibc] [PATCH] klibc: reproducible builds

[Maciej Żenczykowski]

>
> > +KLIBCAR_cru      := $(KLIBCAR) $(if $(KBUILD_REPRODUCIBLE),Dcr,cru)
>
> Did you mean to drop 'u' here?
>

Yeah, Dcru is not valid.

It'd probably be clearer to have a macro that gets called:
>
> KLIBCAR := $(AR)
> # Macro that invokes KLIBCAR.  Takes an argument of ar commands.  Will
> specify "D" to ar if we wish to skip timestamps.
> invoke-KLIBCAR = $(KLIBCAR) $(if $(KBUILD_REPRODUCIBLE),D)$(1)
>
> So this:
>
> -                    rm -f $@; $(KLIBCAR) cru $@ $(filter $(lib-y), $^),\
> -                    rm -f $@; $(KLIBCAR) crs $@)
>
> becomes
>
> +                   rm -f $@; $(call invoke-KLIBCAR,cru) $@ $(filter
> $(lib-y), $^),\
> +                   rm -f $@; $(call invoke-KLIBCAR,crs) $@)
>
> Just a suggestion :)
>

But see above...

-- 
Maciej A. Żenczykowski
Kernel Networking Developer @ Google
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.zytor.com/pipermail/klibc/attachments/20101020/90a8c01e/attachment.html>