[klibc] [PATCH 6/8] switch_root: Fix single file mounts

maximilian attems max at stro.at
Mon Aug 1 13:17:59 PDT 2011


On Mon, Aug 01, 2011 at 03:14:31PM -0400, Peter Jones wrote:
> On 07/29/2011 12:27 PM, H. Peter Anvin wrote:
> > On 07/29/2011 06:40 AM, Michal Suchanek wrote:
> >> union squashfs content and tmpfs over new_root using aufs, unionmount or
> >> whatever els
> > 
> > This appears to be the key part of this usecase.  The various union
> > mounting bits didn't exist when this code was written.
> > 
> > In *this particular* use case, the correct semantics is to leave the
> > mount alone, together with any directory needed as scaffolding.  This is
> > somewhat noteworthy that some other use cases which have been proposed
> > have different requirements.
> > 
> > I would prefer this to bee an option, e.g. --keep-mounts, but perhaps
> > that's overkill?
> 
> Wouldn't it make more sense to simply check if it's a union mount and then
> ignore it?  Makes the cascade back up the directory tree a little more complex,
> but it's not the worst thing ever.

I think the option is overkill, as I would have to enable it in Debian
by default. Currently the util-linux switch_root() ignores the case
anyway and goes on removing the rest it can do.

I was about to "emulate" the util-linux lax behaviour, which allows
boxes to boot in such cases.

-- 
maks



More information about the klibc mailing list