[klibc] [PATCH 5/7] ipconfig: dump_device_config() check return of snprintf()

maximilian attems max at stro.at
Tue Jul 5 11:06:30 PDT 2011


Signed-off-by: maximilian attems <max at stro.at>
---
 usr/kinit/ipconfig/main.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/usr/kinit/ipconfig/main.c b/usr/kinit/ipconfig/main.c
index 6ad5588..8004ad5 100644
--- a/usr/kinit/ipconfig/main.c
+++ b/usr/kinit/ipconfig/main.c
@@ -123,8 +123,11 @@ static void dump_device_config(struct netdev *dev)
 {
 	char fn[40];
 	FILE *f;
+	int len;
 
-	snprintf(fn, sizeof(fn), "/tmp/net-%s.conf", dev->name);
+	len = snprintf(fn, sizeof(fn), "/tmp/net-%s.conf", dev->name);
+	if (len >= sizeof(fn))
+		return;
 	f = fopen(fn, "w");
 	if (f) {
 		write_option(f, "DEVICE", dev->name);
-- 
1.7.5.4



More information about the klibc mailing list