[klibc] [PATCH] Don't try to guess the nameserver in ipconfig.

Ulrich Dangel uli at spamt.net
Wed Jun 8 13:53:50 PDT 2011

klibcs ipconfig tries to guess the nameserver if no nameserver is
provided. This may happen due to misconfigured dhcp or the use of
the ip= parameter.

This patch removes the guessing from ipconfig as it is not possible for
any other script to determine if the provided nameserver is valid or
a guessed one. If the old behavior is really needed this could be easily
implemented in an external script.

Closes: #594638

Signed-off-by: Ulrich Dangel <uli at spamt.net>
 usr/kinit/ipconfig/main.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/usr/kinit/ipconfig/main.c b/usr/kinit/ipconfig/main.c
index 4833bb7..0fd35c1 100644
--- a/usr/kinit/ipconfig/main.c
+++ b/usr/kinit/ipconfig/main.c
@@ -176,11 +176,6 @@ static void postprocess_device(struct netdev *dev)
 		printf("IP-Config: %s guessed broadcast address %s\n",
 		       dev->name, my_inet_ntoa(dev->ip_broadcast));
-	if (dev->ip_nameserver[0] == INADDR_ANY) {
-		dev->ip_nameserver[0] = dev->ip_server;
-		printf("IP-Config: %s guessed nameserver address %s\n",
-		       dev->name, my_inet_ntoa(dev->ip_nameserver[0]));
-	}
 static void complete_device(struct netdev *dev)

More information about the klibc mailing list