[klibc] [PATCH] arm: use bx on thumb2 v3
max at stro.at
Tue May 17 13:44:47 PDT 2011
On Tue, May 17, 2011 at 07:10:33PM +0100, Dave Martin wrote:
> On Tue, May 17, 2011 at 06:17:10PM +0200, maximilian attems wrote:
> > --- a/usr/include/arch/arm/klibc/asmmacros.h
> > +++ b/usr/include/arch/arm/klibc/asmmacros.h
> > @@ -27,4 +27,10 @@
> > (((x) & ~0xf000000f) == 0) || \
> > (((x) & ~0xc000003f) == 0))
> > +#if _KLIBC_ARM_USE_BX
> > +# define BX(x) bx ##x
> > +#else
> > +# define BX(x) mov pc, ##x
> > +#endif
> > +
> What's the ## for? The C preprocessor collapses whitespace around this
> operator, so won't this expand to strings like "bxlr" in the _KLIBC_ARM_USE_BX
good catch, had tested the mov pc, x case on the debian parter box.
will just remove them on the merged patch.
> Otherwise this looks OK, though I'm not a klibc expert.
thanks for review.
More information about the klibc