[klibc] [PATCH 2/2] loop: switch to linux/loop.h

Dimitri John Ledkov xnox at ubuntu.com
Fri Nov 1 07:40:24 PDT 2019

On Fri, 1 Nov 2019 at 14:36, Ben Hutchings <ben at decadent.org.uk> wrote:
> On Thu, 2019-10-31 at 22:59 +0000, Dimitri John Ledkov wrote:
> > linux/loop.h header is exported by linux, for userspace to
> > consume. This would prevent issues with struct sizes
> > incompatibilities.
> [...]
> The structure definitions can't change in future, so I don't think
> that's a real issue after the previous patch.  But I agree that we
> should prefer using the kernel's UAPI headers wherever possible.

Correct, this was my thinking too.

But for example, I did not check how far back UAPI loop.h was
provided, and whether users have it available at klibc build time. And
kind of wanted to show the bug with current loop.h, such that it's
available for cherrypicking & backports.

But indeed, either of the two patches fixes the identified problem.
One is minimal, and this one is slightly more invasive.



More information about the klibc mailing list