[klibc] [PATCH 2/2] loop: switch to linux/loop.h

Adam Conrad adconrad at 0c3.net
Mon Nov 4 09:44:06 PST 2019

On Fri, 1 Nov 2019 at 14:40:24, Dimitri John Ledkov wrote:
> On Fri, 1 Nov 2019 at 14:36, Ben Hutchings <ben at decadent.org.uk> wrote:
> > The structure definitions can't change in future, so I don't think
> > that's a real issue after the previous patch.  But I agree that we
> > should prefer using the kernel's UAPI headers wherever possible.
> But for example, I did not check how far back UAPI loop.h was
> provided, and whether users have it available at klibc build time. And
> kind of wanted to show the bug with current loop.h, such that it's
> available for cherrypicking & backports.

I checked as far back as 3.2 (does anyone other than RHEL care about
kernels older than that and, frankly, do we care to support them?),
and linux/loop.h is exported there and is certainly more correct than
the version shipped in klibc.

While I originally encouraged you to submit both patches, I think I'm
now firmly in the "scorched earth" camp, where we should just trust
that the kernel has it right, and stop trying to duplicate it.

So, unless there are strong objections, please take this version of
the patch.

... Adam

More information about the klibc mailing list