[klibc] [kvm-unit-tests PATCH v3 0/4] Update patch set

Ben Hutchings ben at decadent.org.uk
Sun Jul 26 13:52:57 PDT 2020


On Sat, 2020-07-25 at 23:13 -0700, Bill Wendling wrote:
> On Sat, Jul 25, 2020 at 4:10 PM Ben Hutchings <ben at decadent.org.uk> wrote:
> > On Sat, 2020-07-25 at 15:16 -0700, Bill Wendling wrote:
> > > On Sat, Jul 25, 2020 at 2:56 PM Ben Hutchings <ben at decadent.org.uk> wrote:
> > > > On Sat, 2020-07-25 at 14:36 -0700, Bill Wendling wrote:
> > > > [...]
> > > > > I upstreamed a few patches to klibc to fix a few linker errors. Some
> > > > > of these might help:
> > > > 
> > > > I applied v3 of your patch series and never saw this later version.
> > > > 
> > > > >   - cfc4e4c9591c73edc786aebbe83b371fec36fec8 - Conditionalized
> > > > > non-supported flags.
> > > > >   - 1b014f8401fc5b3dc803e2cae06ac5c803dc89cb -  Add "-fno-common"
> > > > >   - 1e876662002eac9662357c7feaee12be04107d32 - Use proper libc
> > > > >   - f07a8f75b8ebfea71254cd8829c0476b6b6683e1 - Adjust some flags for ld.lld
> > > > >   - 7f0aa03493dc9ab8c1d2798f6586bfbc5f1de702 - Use "-ffreestanding"
> > > > > (fixes using unlocked versions of calls)
> > > > > 
> > > > > There are also a bunch of clang warnings Michael Davidson fixed in the
> > > > > klibc tree.
> > > > 
> > > > *Which* klibc tree?
> > > > 
> > > > Ben.
> > > > 
> > > The one here I think: https://git.kernel.org/pub/scm/libs/klibc/klibc.git
> > 
> > That's where I'm pushing.  It has v3 of your patch series, and no other
> > recent changes related to Clang or lld.
> > 
> > So please send over any other fixes you have.
> > 
> Hi Ben,
> 
> I'm sorry. I don't know what you want. The patches I see in
> top-of-tree klibc look to be the ones I listed above. Though I don't
> see the -ffreestanding and the -Ttext-segment changes
[...]

OK.  The -ffreestanding change should not be necessary after this:
https://git.kernel.org/pub/scm/libs/klibc/klibc.git/commit/?id=8c056cab6c8cce0b5dbc2c3141060f89a6ffc905

The change to replace -Ttext-segment is there as:
https://git.kernel.org/pub/scm/libs/klibc/klibc.git/commit/?id=eaca2447991709cddfd8c42f3fa4a2e890d2cce8

However, ld.lld 9.0.1 fails to link programs using the klibc shared
library.

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice - John Levine

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.zytor.com/archives/klibc/attachments/20200726/994bba3f/attachment.sig>


More information about the klibc mailing list