[klibc] [PATCH v2 5/5] Clean up clang warnings

Ben Hutchings ben at decadent.org.uk
Sat Mar 28 09:23:43 PDT 2020

On Fri, 2020-03-27 at 15:29 -0700, Bill Wendling wrote:
> - Convert the "old style" GNU field designator extension to the new
>   style.
> - Use proper indexing into a string literal.
> - Use "%s" for the format string in "fmtstr".
> - Add or remove casts of the "void *" argument of ioctl.
> - Convert "if (!exitstatus == isor)" to "if ((!exitstatus) == isor)"
>   which retains the current semantics, but may not be what the
>   programmer intended.

This is all good, but I don't want to diverge from upstream dash more
than necessary.  I want to upgrade to the current version of dash,
which appears to have fixed all these warnings but not in exactly the
same way.  The reason I haven't done so already is that I don't have
regression tests for dash.

I've cherry-picked the two upstream dash changes that will apply
cleanly, so that at least reduces the number of warnings you'll see.

Can you change this to just fix kinit for now?


Ben Hutchings
This sentence contradicts itself - no actually it doesn't.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.zytor.com/archives/klibc/attachments/20200328/ba07e0d5/attachment.sig>

More information about the klibc mailing list