[klibc] [klibc:update-dash] dash: options: Do not set commandname in procargs

klibc-bot for Herbert Xu herbert at gondor.apana.org.au
Sat Mar 28 14:49:39 PDT 2020


Commit-ID:  871ec43d428db7327b73ecc099e0ab680a32ab4d
Gitweb:     http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=871ec43d428db7327b73ecc099e0ab680a32ab4d
Author:     Herbert Xu <herbert at gondor.apana.org.au>
AuthorDate: Mon, 25 Feb 2019 12:49:20 +0800
Committer:  Ben Hutchings <ben at decadent.org.uk>
CommitDate: Sat, 28 Mar 2020 21:42:55 +0000

[klibc] dash: options: Do not set commandname in procargs

[ dash commit e7a5030483e039971aad59db3fc238c3051bd565 ]

We set commandname in procargs when we don't have to.  This results
in a duplicated output of arg0 when an error occurs.

Reported-by: Olivier Duclos <odc at fastmail.com>
Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>
Signed-off-by: Ben Hutchings <ben at decadent.org.uk>

---
 usr/dash/options.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/usr/dash/options.c b/usr/dash/options.c
index 6f381e61..a46c23b9 100644
--- a/usr/dash/options.c
+++ b/usr/dash/options.c
@@ -159,7 +159,6 @@ procargs(int argc, char **argv)
 		setinputfile(*xargv, 0);
 setarg0:
 		arg0 = *xargv++;
-		commandname = arg0;
 	}
 
 	shellparam.p = xargv;


More information about the klibc mailing list